Re: Writing a query ...

Aside from using dynamic sql, there is nothing wrong with this. Other ways
of doing it will decrease the amount of code, but will lead to less
efficient queries. There are some good articles here:
http://www.sommarskog.se/ - read the one about dynamic search conditions
(and then read the one about dynamic sql)

Here is my canned reply about dynamic sql:

Further points to consider:
Your use of dynamic sql is leaving you vulnerable to hackers using sql
injection:
http://mvp.unixwiz.net/techtips/sql-injection.html
http://www.sqlsecurity.com/DesktopDefault.aspx?tabid=23

See these links for a better, more secure way to execute your queries by
using
parameter markers:
http://groups-beta.google.com/group/microsoft.public.inetserver.asp.db/msg/72e36
562fee7804e

Using Command object to parameterize CommandText:
http://groups-beta.google.com/group/microsoft.public.inetserver.asp.db/msg/72e36
562fee7804e
Select statement:
http://groups-beta.google.com/group/microsoft.public.inetserver.asp.db/msg/b3d32
2b882a604bd

Personally, I prefer using stored procedures,
http://groups.google.com/group/microsoft.public.inetserver.asp.general/msg/5d3c9
d4409dc1701?hl=en&

Thank you for your reply Evertjan!

I am using SQL Server with ASP Classic.  This is not a school project
(though I want to take some classes), I am a IT Project Manager trying
to learn code and modify existing projects.  Here is what the query
currently looks like, it gets the job done.  I want to learn and
understand if this process can be done better.

if request.querystring("StatusDisplay")="" then

strSql = " SELECT CustID, FName, LName, SubLevel FROM CustInfo"

Else

strSql = " SELECT CustID, FName, LName, SubLevel FROM CustInfo WHERE
SubLevel="  & request.querystring("sublevel")

End If

bcap wrote on 25 jul 2009 in microsoft.public.inetserver.asp.general:

Better than what?

Show us your code, only the essence please.

No, let us hear what engine you are using.

Is this a school assignment?
Did you read some of the many SQL tutorials?

What is a "status type"?

Learning is not letting someone else do the task!

Hi,

I am looking to write a piece of code better.

Lets say I have a table called CustInfo with CustID, FirstName,
LastName, and Subscription Level for simplicity.

How can I create a query that I would be to:

1)  Get all records no matter what subscription level they are in
2)  Choose only records that have a selected status types
3)  Declare that there are no records

Currently, I am using two queries (one that just selects all, another
that needs a parameter) and making a decision based on if there is a
status type.  I'd like to learn a more efficent way to do this.  Any
advise would be appreciated!